decentraland / decentraland-gatsby / 27963649941

56%

Build Type

push

github

Committed by web-flow

Commit Message

refactor: use @dcl http-server and crypto-middleware to drop node-fetch (#1321)

* refactor: use @dcl http-server and crypto-middleware to drop node-fetch

replace @well-known-components/http-server and decentraland-crypto-middleware
with their native-fetch @dcl equivalents from core-components and core-libs.

- @well-known-components/http-server -> @dcl/http-server (getRequestFromNodeMessage)
- IHttpServerComponent now comes from @dcl/core-commons; its IRequest is the
  native (undici) Request, so wkc/request/Request.ts re-exports the global
  Request/RequestInit/RequestInfo instead of node-fetch
- decentraland-crypto-middleware -> @dcl/crypto-middleware (verify, auth header
  consts and types); the verifyMetadataContent option is now metadataValidator
- bump @well-known-components/interfaces to ^1.5.2 to match @dcl/core-commons
  (kept only for the types-only IMiddlewareAdapterHandler)
- tests build native Request with absolute urls (native Request rejects the
  relative urls node-fetch accepted)

removes the http-server and crypto-middleware node-fetch paths. node-fetch still
arrives transitively via gatsby, decentraland-dapps, decentraland-connect and
storybook, so it isn't fully gone from the tree.

* refactor: accept verifyMetadataContent as a deprecated alias of metadataValidator

Address PR review:

[P1] @dcl/crypto-middleware renamed the `verifyMetadataContent` option to
`metadataValidator`. To avoid silently dropping metadata validation for
consumers that still pass the old name (e.g. decentraland/referral, governance),
the auth helpers (auth, withChainHeader, withDecentralandAuth) now accept
`verifyMetadataContent` as a deprecated alias and forward it to
`metadataValidator` via a shared resolveVerifyOptions helper. This keeps the API
backwards compatible, so no major version bump or coordinated downstream
migration is required; the old name is marked @deprecated for eventual removal.
Added a regression test covering the legacy alias.

[P2] ... (continued)

Coverage Stats

502 of 1108 branches covered (45.31%)

Branch coverage included in aggregate %.

9 of 9 new or added lines in 6 files covered. (100.0%)

1 existing line in 1 file now uncovered.

1258 of 2040 relevant lines covered (61.67%)

11.44 hits per line