kobotoolbox / kpi / 27955568361

81%

master: 76%

push

github

refactor(frontend): remove PopoverMenu in favor of Mantine Menu DEV-2303 (#7165)

### 💭 Notes

Replace PopoverMenu with Mantine Menu throughout the codebase.

Changes here:

**Deleted legacy code:**
- `popoverMenu.tsx` / `popoverMenu.scss` - removed entirely (185 lines
of SCSS gone!)
- `bemComponents.ts` - removed all `bem.PopoverMenu*` definitions

**New component:**
- `AssetMoreActions.tsx` - split out from `assetActionButtons.tsx` into
its own file
- Only includes library-relevant actions (manage translations, download
files, move to collection, delete)
- Survey-specific actions were removed, as AssetActionButtons are only
being used in Library context, and we don't plan to use them for surveys
  - "Move to" is now a scrollable nested submenu
- Icons migrated from `<i className>` to `KoboIcon` / `Icon` based on
`KoboIconMappings.ts`

**Migrated to Mantine Menu:**
- `accountMenu.tsx` - uses controlled menu state to properly close after
clicking "Account Settings"
- `tableBulkOptions.tsx` - "Change status" dropdown
- `tableBulkCheckbox.tsx` - bulk actions menu
- `formLanding.js` - "More actions" menu (survey-specific actions)

**Fixed issues:**
- `assetActionButtons.tsx` - `editLanguages()` now fetches full asset
with content before opening modal (list endpoints don't include content,
which caused infinite spinner)
- Changed old `Button` to `ButtonNew` for proper Menu positioning (old
component doesn't forward refs)
- ~~`assetsTable.tsx` - replaced deprecated `ReactDOM.findDOMNode()`
with callback ref pattern (that warning was getting annoying)~~ this
turned out to open can of worms and require more refactor, I'm dropping
it

**SCSS cleanup:**
- Removed all `.popover-menu` references from `assetsTable.scss`,
`tableBulkCheckbox.scss`, `_kobo.navigation.scss`,
`_kobo.table-meta.scss`, `tooltip.scss`
- Added proper class names for the new Menu trigger buttons

The "Move to collection" submenu was the trickiest part - it opens on
hover but also clicks, h... (continued)

9064 of 12305 branches covered (73.66%)

29791 of 36506 relevant lines covered (81.61%)

5.56 hits per line