dangernoodle-io / breadboard / 27921600879

100%

push

github

fix: absorb self-induced disconnect in connect-timeout re-attempt path (#493)

on connect-timeout, the FSM calls esp_wifi_disconnect() before
esp_wifi_connect(). on esp-idf, esp_wifi_disconnect() emits
WIFI_EVENT_STA_DISCONNECTED synchronously before returning, which
bb_wifi.c's event handler converts to a queued EVT_DISCONNECT. without
a guard, reconn_task processes that event via handle_disconnect(), which
calls wifi_reconn_policy_on_disconnect() — bumping generic_fail_count a
second time and issuing a second esp_wifi_connect() that races the one
already issued by the timeout path.

fix: set s_self_disconnect = true before esp_wifi_disconnect() in the
timeout path. wifi_reconn_on_disconnect() checks this flag; if set, it
clears it and returns without enqueuing EVT_DISCONNECT. the flag is
declared volatile so the compiler cannot reorder the store across the
esp_wifi_disconnect() call. the policy-layer fail count and connect
call therefore happen exactly once per timeout event.

the pure policy layer (wifi_reconn_policy.c) is untouched; no new
policy tests are needed. make test: 2409/2409 passed.

1718 of 1718 branches covered (100.0%)

Branch coverage included in aggregate %.

2845 of 2845 relevant lines covered (100.0%)

1227.49 hits per line