dangernoodle-io / breadboard / 27921487930

100%

push

github

fix: abort OTA handle on esp_ota_end failure and malloc failure in ota_push_handler (#492)

- on esp_ota_end failure (422 path): add esp_ota_abort(ota_handle) before goto
  resume_and_exit — esp_ota_end on error does NOT free the handle; without the
  abort the partition handle leaks and the partially-written partition is abandoned
- on malloc failure (500 path): add esp_ota_abort(ota_handle) and
  bb_ota_emit_progress(FAIL) to match every other error path after a successful
  esp_ota_begin; the old code returned directly, leaking the handle and skipping
  the fail progress event
- esp_ota_set_boot_partition failure (500) is correct: esp_ota_end already
  succeeded (consuming the handle), so no abort is needed there
- all receive-loop error paths (408 deadline/timeout, 500 write/recv error, 400
  board mismatch) already called esp_ota_abort correctly before this change

Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>

1718 of 1718 branches covered (100.0%)

Branch coverage included in aggregate %.

2845 of 2845 relevant lines covered (100.0%)

1227.49 hits per line