grpc
/
grpc-java
/
#20329
89%
|
Ran
|
Jobs
1
|
Files
658
|
Run time
1min
|
Badge
Embed ▾
README BADGES
|
coverage: 88.874% (-0.007%) from 88.881%
push
github
web-flowRevert "servlet: fix write when not ready in AsyncServletOutputStreamWriter (#12867) This reverts commit 243b79ee5. The approach taken of ensuring subsequent writes go through the container thread via onWritePossible() hasn't eliminated the need for catching the IllegalStateException (which you are catching and buffering the write if it happens). We have observed that the UndertowInteropTest now hangs instead of the earlier flaky failures due to uncaught exception. There has been another PR https://github.com/grpc/grpc-java/pull/12732 for the same issue that explicitly checks isReady.getAsBoolean() in addition to the cached state, that's probably most reliable, because you don't have to deal with callback scheduling and the state changing in the meantime. We would like to proceed with that PR and revert this one. @mgustimz
36529 of 41102 relevant lines covered (88.87%)
0.89 hits per line
Coverage Regressions
| Lines | Coverage | ∆ | File |
|---|---|---|---|
| 4 |
74.23 |
-4.12% | ../servlet/src/main/java/io/grpc/servlet/AsyncServletOutputStreamWriter.java |
| 3 |
90.63 |
-0.59% | ../netty/src/main/java/io/grpc/netty/NettyServerHandler.java |
| 3 |
75.0 |
-1.72% | ../servlet/src/main/java/io/grpc/servlet/ServletServerStream.java |
| 1 |
96.57 |
-0.57% | ../core/src/main/java/io/grpc/internal/DelayedClientTransport.java |
| 1 |
87.6 |
-0.83% | ../rls/src/main/java/io/grpc/rls/LinkedHashLruCache.java |
| 1 |
91.59 |
-0.47% | ../xds/src/main/java/io/grpc/xds/client/ControlPlaneClient.java |
Jobs
| ID | Job ID | Ran | Files | Coverage | |
|---|---|---|---|---|---|
| 1 | #20329.1 | 658 |
88.87 |
