trickstercache / trickster / 27905134870

89%

main: 89%

Build Type

Pull #1029

github

Committed by thinker0

Commit Message

fix: [alb] expose localresponse via Handlers() so paths: overrides apply

The ALB client's Handlers() lookup previously returned only the ALB
mechanism handler, so any `paths:` override in the YAML that named a
generic handler (e.g. `handler: localresponse`) was silently dropped by
RegisterPathRoutes — `handlers[p.HandlerName]` returned nil, leaving
p.Handler unset and skipping route registration.

Operators that want to short-circuit non-mergeable endpoints (such as
/api/v1/query_exemplars or /api/v1/metadata) before they enter a TSM
fanout — where nil MergeFunc on every member surfaces as a client 502
via HandleBadGateway — now have a working escape hatch:

    backends:
      alb:
        provider: alb
        alb:
          mechanism: tsm
          pool: [...]
        paths:
          - path: /api/v1/query_exemplars
            handler: localresponse
            match_type: exact
            methods: [GET, POST]
            response_code: 200
            response_body: '{"status":"success","data":[]}'
            response_headers:
              Content-Type: application/json

The patch is purely additive: providers.ALB stays mapped to the existing
mechanism handler, so all existing route registration and tests
(TestNewClient, TestHandlers, etc.) continue to behave identically. The
local handler package is already imported by reverseproxy and
reverseproxycache for the same purpose.

(cherry picked from commit dc7560ea0)
Signed-off-by: thinker0 <thinker0@gmail.com>

Pull Request Pull Request #1029: fix: [alb] expose localresponse via Handlers() so paths: overrides apply

Coverage Stats

4 of 4 new or added lines in 1 file covered. (100.0%)

2 existing lines in 1 file now uncovered.

20746 of 23282 relevant lines covered (89.11%)

1.55 hits per line