trickstercache / trickster / 27889223784

89%

Build Type

push

github

Committed by web-flow

Commit Message

fix: [listener] correct active-connections gauge under connections_limit (#1019)

* fix: [listener] correct active-connections gauge under connections_limit

Accept() only wrapped *net.TCPConn in observedConnection, so when frontend.connections_limit is set the netutil.LimitListener-wrapped conn (not a *net.TCPConn) was returned unwrapped and its Close never decremented trickster_proxy_active_connections -- the gauge climbed monotonically and ignored the configured limit. Accept now wraps every accepted conn except *tls.Conn (left bare so http.Server can negotiate HTTP/2 via ALPN).

observedConnection embeds net.Conn and decrements the gauge only on the first successful Close. net/http may close the same conn more than once; the repeat Close returns an error, which now guards the decrement (replacing the previous sync.Once).

Tests assert a repeated Close returns an error and the gauge nets a single decrement, and that Accept wraps a LimitListener conn.

Signed-off-by: thinker0 <thinker0@gmail.com>

* refactor: [proxy] adopt idiomatic error-first return for observedConnection.Close

Signed-off-by: thinker0 <thinker0@gmail.com>

---------

Signed-off-by: thinker0 <thinker0@gmail.com>

Coverage Stats

10 of 11 new or added lines in 1 file covered. (90.91%)

1 existing line in 1 file now uncovered.

20745 of 23279 relevant lines covered (89.11%)

1.55 hits per line