decentraland / comms-gatekeeper / 27886116360

85%

Build Type

push

github

Committed by web-flow

Commit Message

refactor: migrate to native fetch and @dcl/core-commons components (#266)

* refactor: migrate to native fetch and @dcl/core-commons components

Replace node-fetch with the native (undici) fetch across the service and move
onto the @dcl/core-commons-based component stack.

Dependencies:
- Add @dcl/core-commons, @dcl/traced-fetch-component, @dcl/crypto-middleware@3
  (replacing @dcl/platform-crypto-middleware) and passport-strategy
- Bump @dcl/http-server and @dcl/http-commons to v2, @dcl/schema-validator-component
  to v1, @dcl/memory-cache-component to 2.4.2, @dcl/analytics-component to 1.0.3 and
  dcl-catalyst-client to 21.11.0
- Drop @well-known-components/fetch-component and @well-known-components/http-server
- Remove the local src/adapters/traced-fetch.ts adapter

Type the shared fetch component (components.fetch) as the native @dcl/core-commons
IFetchComponent. The only remaining node-fetch bridges are at the boundaries of
libraries not yet migrated (@well-known-components/features-component and the WKC
server-instrumentation helpers).

Fix two latent @dcl/analytics-component END_CALL payloads surfaced by the stricter
fireEvent typing in v1: the private path used the wrong field names, and user_id is
now optional since community calls end at the room level with no single user.

* refactor: adopt @dcl/core-commons components and upgrade crypto-middleware to v4

Continue the native-fetch migration by replacing more WKC packages with their
@dcl/core-commons-based equivalents and dropping the now-unnecessary bridges.

- Upgrade @dcl/crypto-middleware to v4 (same public API) and remove passport-strategy,
  which v4 no longer imports
- Replace @well-known-components/features-component with @dcl/features-component, whose
  fetch is the native @dcl/core-commons IFetchComponent; pass tracedFetch directly with
  no cast
- Replace @well-known-components/http-tracer-component with @dcl/http-tracer-component
- Instrument HTTP metrics via @dcl/http-server's i... (continued)

Coverage Stats

1052 of 1358 branches covered (77.47%)

Branch coverage included in aggregate %.

23 of 23 new or added lines in 5 files covered. (100.0%)

2 existing lines in 1 file now uncovered.

2963 of 3354 relevant lines covered (88.34%)

74.74 hits per line