lsm / neokai / 27863619682

82%

push

github

feat(external-events): poll GitHub PR reactions for review approvals (#2139)

* feat(external-events): poll GitHub PR reactions for review approvals

GitHub extension polled comments, reviews, and PR metadata but not
reactions, so codex[bot] +1 approvals never fired reaction_added
events needed by review gates.

- Poll /repos/{owner}/{repo}/issues/{number}/reactions for the 10
  most recently active PRs each cycle (configurable via cursor).
- Publish +1 and thumbs_up reactions as
  github/{owner}/{repo}/pull_request/{number}.reaction_added with
  source-level dedupe by reaction id.
- Track X-RateLimit-Remaining across polling responses and skip
  reaction calls when remaining drops below 100.
- Webhook registration unchanged; PR reactions are polling-only.

* fix(external-events): address review feedback on reaction polling

- Preserve finite rate-limit budget across 304s: mergeRateLimitInfo keeps
  the prior finite remaining when a cached 304 reports Infinity, so the
  reaction-poll < 100 guard still trips on a low prior budget.
- Keep newest PRs for reaction polling: /pulls returns newest-first, so a
  fresh (non-304) page resets recentPullRequestNumbers to the first 10
  observed PR numbers instead of unshift+truncate which kept the oldest.
- Seed reaction targets on upgrade: when a pre-feature cursor has an
  pulls ETag but no recentPullRequestNumbers, skip If-None-Match once so
  the first cycle populates the list instead of 304-ing forever.
- Mirror secondary-limit handling in the reaction loop: a 403/429 with a
  secondary-rate-limit body now applies the short backoff and stops the
  loop instead of falling through to continue and burning more requests.

Add a test asserting the newest-10 PRs are polled for reactions when
/pulls returns more than the limit.

* fix(external-events): guard reaction-target updates to pulls page 1

Round-2 review feedback:

- Only fold reaction-poll targets from /pulls page 1. Page 2+ during
  backlog drain contain... (continued)

10878 of 15826 branches covered (68.73%)

Branch coverage included in aggregate %.

199 of 199 new or added lines in 2 files covered. (100.0%)

92994 of 111246 relevant lines covered (83.59%)

296.61 hits per line