lsm / neokai / 27854099564

82%

Build Type

push

github

Committed by web-flow

Commit Message

feat: complete SDK system-message rendering matrix (render 5, hide 9, conditional 2) (#2129)

* feat: complete SDK system-message rendering matrix (render 5, hide 9, conditional 2)

Implement rendering decisions for all SDK system message subtypes not covered by #620:

**Render gaps fixed (5 new renderers):**
- permission_denied: Compact amber/rose card with tool_name and reason
- task_notification: Subagent completion card with usage stats (tokens, tool uses, duration)
- memory_recall: Collapsible "Memory recalled" card listing paths/scopes
- local_command_output: Plaintext rendering for slash command output
- notification: Priority banner (low/medium/high/immediate) with color support

**Hidden subtypes (9 - consolidated to single source of truth):**
- session_state_changed, commands_changed, hook_started, hook_progress
- task_started, task_progress, task_updated, mirror_error, elicitation_complete
All hidden via explicit HIDDEN_SYSTEM_SUBTYPES Set in type-guards.ts

**Conditional rendering (2):**
- files_persisted: Render only when failed.length > 0 (show failures)
- plugin_install: Render on failed/completed, hide 'started'

**Implementation:**
- Single source of truth: HIDDEN_SYSTEM_SUBTYPES Set in type-guards.ts
- isHiddenSystemSubtype() helper for consistent gate checks
- isRenderableSystemMessage() simplified to !isHiddenSystemSubtype(subtype)
- Conditional logic lives in SDKSystemMessage component (returns null when unmet)
- Verified hide-bucket consumers: SessionInfoPanel reads metadata, doesn't render chat rows

**Tests:**
- 66 SDKSystemMessage tests (5 new renderers, 9 hidden, 2 conditional)
- 76 type-guards tests (isHiddenSystemSubtype coverage)
- Updated 3 existing tests for hidden subtypes (thinking_tokens, session_state_changed)

All changes persist to DB; only rendering decisions changed.

* fix: address review feedback - permission_denied removed, session_state_changed deduped, notification priority fallback

**P1 - permission_denied... (continued)

Coverage Stats

10878 of 15826 branches covered (68.73%)

Branch coverage included in aggregate %.

99 of 99 new or added lines in 8 files covered. (100.0%)

12 existing lines in 2 files now uncovered.

92457 of 110714 relevant lines covered (83.51%)

297.34 hits per line