ultimate-notion / ultimate-notion / 27847149720

87%

push

github

Set mypy to strict mode (#235)

* Set mypy to strict mode

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* Resolve strict-mode type errors at the source

Strict mode newly enables no_implicit_reexport and strict_equality.
Rather than blanket-ignoring the resulting errors, fix them properly:

- Import re-exported names from their defining module (e.g. core types
  from obj_api.core, DateTimeOrRange from utils, render_md from markdown,
  User from user, MAX_PAGE_SIZE from obj_api.iterator, Result from
  click.testing) so no_implicit_reexport is satisfied without churn.
- Call pendulum's local_timezone via `from pendulum.tz import
  local_timezone` to avoid the submodule/function name collision that
  made mypy see a module ("Module not callable").
- Give the children-tuple and Workspace-sentinel comparisons types that
  keep the intended runtime checks while satisfying strict_equality.

Scope missing-import handling instead of a blanket ignore:

- Drop the global ignore_missing_imports; add per-module overrides only
  for libraries that genuinely ship no types (googleapiclient,
  google_auth_oauthlib, IPython, mktestdocs, vcr).
- Add the typed deps (pytest, hypothesis, pandas-stubs) to the lint env
  so they are type-checked for real. This surfaced and fixed real bugs
  in conftest: CallInfo[Any], an excinfo None-guard, config.rootpath
  over the untyped rootdir, and a Literal scope for vcr_fixture.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

23 of 23 new or added lines in 11 files covered. (100.0%)

6536 of 7436 relevant lines covered (87.9%)

6.12 hits per line