decentraland / lamb2 / 27846119065

83%

push

github

chore: replace WKC packages with core-components equivalents + native fetch (#466)

* chore: replace WKC packages with core-components equivalents

Swap the @well-known-components packages that have published
core-components equivalents for their @dcl counterparts:

- @well-known-components/http-server -> @dcl/http-server
- @well-known-components/metrics -> @dcl/metrics

@dcl/http-server types its server against IHttpServerComponent from
@dcl/core-commons, which binds request/response to Node's native fetch
(global Request) instead of node-fetch. To keep the stack consistent:

- point IHttpServerComponent in src/types.ts and errorHandler.ts at
  @dcl/core-commons (added as a dependency)
- bump @dcl/schema-validator-component to 1.0.0 (the core-components
  version); its middleware returns a core-commons-typed handler, so the
  previous 0.3.1 (WKC-typed) would not register on the new router
- drop the node-fetch Request import in two unit tests so they use the
  global Request the handlers now expect
- enable skipLibCheck (the published @dcl/http-server types reference its
  ws devDep, which is not installed transitively)

The remaining WKC packages (interfaces, logger, env-config-provider,
thegraph-component, test-helpers) have no core-components equivalent and
are kept as-is.

* chore: replace thegraph-component and migrate to native fetch

Continue replacing WKC packages with their core-components equivalents and
adopt the native-fetch stack now that dcl-catalyst-client supports it.

thegraph:
- @well-known-components/thegraph-component -> @dcl/thegraph-component

fetch / catalyst:
- bump dcl-catalyst-client to ^21.11.0, whose IFetchComponent accepts both
  the node-fetch and native (@dcl/core-commons) fetchers
- replace the custom node-fetch port (src/ports/fetch.ts) with
  @dcl/fetch-component (native, core-commons-typed)
- type the app-wide `fetch` as the @dcl/core-commons IFetchComponent, which
  lets @dcl/thegraph-component receive a native fet... (continued)

720 of 962 branches covered (74.84%)

Branch coverage included in aggregate %.

14 of 14 new or added lines in 4 files covered. (100.0%)

2032 of 2346 relevant lines covered (86.62%)

47.7 hits per line