agama-project / agama / 27829922750

83%

push

github

refactor(web): fine-tune and extend the appearance system (#3647)

## Summary

A follow-up to #3604 (the dark / high-contrast styles and the
`--agm-t--*` role layer), started while investigating the font-rendering
report #3632.

- Fix thin / inconsistent font rendering (update the SUSE variable font
to v2.001, declare proper variable-font `@font-face` ranges, drop the
custom font-weight overrides).
- Extend the Agama `--agm-t--*` role layer to typography: font
**family**, **weight** and **size**, plus a unified numbered
**icon-size** scale.
- Defaults are unchanged: every new hook is unset and falls back to the
previous value, so the shipped look is the same on supported browsers.

## Motivation

This builds on #3604 (dark / high-contrast styles), which introduced the
curated `--agm-t--*` role layer and per-product appearance overrides.

It started from the font-rendering report in #3632: a Pale Moon user
sees text that is too thin and bold that is inconsistent. Pale Moon
(Goanna engine) is **not a browser we support**, but while checking
whether we could still help there we found a few genuine issues and the
expected room for improvement after such a recent change:

- The SUSE faces declared a single `font-weight` (or none) and no
variable-font `format()` hint, so engines could treat them as static
fonts.
- Agama forced `--pf-t--global--font--weight--100..400` to
`100/600/700/800`, i.e. body text at weight 100 (Thin). Modern browsers
render that fine, but it can turn out too light on weaker engines or
low-resolution displays.
- Typography and icon sizes were not part of the `--agm-t--*` token API
yet, so there was no clean way to fine-tune them per product.
- A few appearance details (icon color, disabled background, tooltip
colors) were also not exposed as roles, so they could not be themed
without reaching into PatternFly tokens.

## Changes

### Font rendering:

- **Update the SUSE variable font to v2.001** (full 100-900 weight axis;
the previous ... (continued)

4772 of 6683 branches covered (71.41%)

Branch coverage included in aggregate %.

25071 of 29318 relevant lines covered (85.51%)

124.74 hits per line