decentraland / lamb2 / 27824303898

83%

main: 83%

Build Type

Pull #466

github

Committed by LautaroPetaccio

Commit Message

chore: replace WKC packages with core-components equivalents

Swap the @well-known-components packages that have published
core-components equivalents for their @dcl counterparts:

- @well-known-components/http-server -> @dcl/http-server
- @well-known-components/metrics -> @dcl/metrics

@dcl/http-server types its server against IHttpServerComponent from
@dcl/core-commons, which binds request/response to Node's native fetch
(global Request) instead of node-fetch. To keep the stack consistent:

- point IHttpServerComponent in src/types.ts and errorHandler.ts at
  @dcl/core-commons (added as a dependency)
- bump @dcl/schema-validator-component to 1.0.0 (the core-components
  version); its middleware returns a core-commons-typed handler, so the
  previous 0.3.1 (WKC-typed) would not register on the new router
- drop the node-fetch Request import in two unit tests so they use the
  global Request the handlers now expect
- enable skipLibCheck (the published @dcl/http-server types reference its
  ws devDep, which is not installed transitively)

The remaining WKC packages (interfaces, logger, env-config-provider,
thegraph-component, test-helpers) have no core-components equivalent and
are kept as-is.

Pull Request Pull Request #466: chore: replace WKC packages with core-components equivalents

Coverage Stats

720 of 963 branches covered (74.77%)

Branch coverage included in aggregate %.

4 of 4 new or added lines in 4 files covered. (100.0%)

6 existing lines in 1 file now uncovered.

2029 of 2351 relevant lines covered (86.3%)

47.54 hits per line