Freegle / Iznik / 22427

71%

master: 71%

Pull #826

circleci

fix(myposts): age out old posts pinned active by unrelated shared-room chat

Years-old posts kept reappearing in a member's active My Posts (Discourse
9481/583). Verified in prod for the three posts the reporter named:
70022383/70023547 (Rejected, 2020, no outcome) show active; 70516224
(Rejected, 2020, Withdrawn outcome) correctly shows Old.

Root cause is NOT arrival-vs-date (their arrival already equals their 2020
date) and NOT pending. applyExpiry correctly flags all three as past expiry,
but the recentChat guard then keeps them active because it measured recency
with MAX(chat_rooms.latestmessage) - the whole room's last message. Freegle
user-to-user rooms are one long-lived room per pair of people, so any recent
message between the two users (here, 3 days ago, about something else) made
every old post they ever referenced in that room look "actively discussed".
The post-specific chat reference for all three was 2020. 70516224 only
escaped to Old via its separate Withdrawn outcome.

Fix: judge recency by the latest chat message that actually references the
post (MAX(chat_messages.date) WHERE refmsgid = the post), not the room's
overall last message. A genuinely active post still has a recent reference
and stays active (TestExpiredMessageWithRecentChatKeptActive, unchanged); an
old post whose discussion ended ages ago now ages out even if the shared
room is still busy.

Test: TestExpiredMessageHeldActiveByUnrelatedRoomChatAgedOut - old post +
recent room latestmessage + an OLD refmsgid reference must age out of active.
Fails on the old room-level query, passes on the per-post query.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

11032 of 14664 branches covered (75.23%)

Branch coverage included in aggregate %.

3 of 3 new or added lines in 1 file covered. (100.0%)

120292 of 171506 relevant lines covered (70.14%)

35.91 hits per line