ultimate-notion / ultimate-notion / 27814964811

87%

push

github

Drop metaclass type: ignores by moving get_props onto SchemaType (#209)

The `SchemaType.__len__`, `__iter__`, and `__getattr__` metaclass methods
annotated their receiver as `cls: type[Schema]` so their bodies could call
`cls.get_props()`, but mypy requires the receiver to be a supertype of the
containing class (the metaclass), producing `[misc]` "Self argument missing"
errors suppressed with `type: ignore`.

`get_props` operates on the schema class itself, not on instances, so it
belongs on the metaclass. Moving it from a `@classmethod` on `Schema` onto
`SchemaType` (and declaring `_props` there) lets mypy infer `cls` as the
metaclass instance and resolve `get_props` without the ignore or the
inaccurate `cls` annotation. Public behaviour (`Schema.get_props()`,
`len(MySchema)`, iteration, attribute access) is unchanged.

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

6 of 6 new or added lines in 1 file covered. (100.0%)

6519 of 7402 relevant lines covered (88.07%)

6.14 hits per line