KarpelesLab / libwallet / 27808088339

24%

push

github

wltwallet: fix wlet→wlt prefix typo on imported wallets + bump 0.4.64

Wallet:importPrivateKey (import.go:130) and Wallet:promoteMnemonic
(promote_mnemonic.go:212) were minting the new wallet row with
xuid.New("wlet") — a typo for the canonical "wlt" prefix used
everywhere else. Any later WalletById() call (and every wallet read
path goes through it) tripped api.go:36's strict
`if id.Prefix != "wlt"` check and returned

    LibwalletException(500): invalid key for wallet: wlet

which the field tester hit on "importing or using an imported
passphrase". A tolerant `x.Prefix != "wlt" && x.Prefix != "wlet"`
workaround existed at transfer.go:577 (papered over the same typo on
the transfer path) but every other reader rejects "wlet" cleanly.

Fix:
  - import.go:130     "wlet" → "wlt"
  - promote_mnemonic.go:212  "wlet" → "wlt"
  - promote_modern_test.go (both sites)  "wlet" → "wlt"
  - transfer.go:577 — tighten the workaround back to strict "wlt".
    "wlet" is illegal at every reader site and must never reach the
    DB again.

Wallets persisted with the bad prefix on prior versions need a
re-import; we deliberately don't accept "wlet" anywhere on the
read side to avoid leaving the typo as an evergreen second-class
prefix in the system.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

1 of 3 new or added lines in 3 files covered. (33.33%)

4496 of 18763 relevant lines covered (23.96%)

101.89 hits per line