KarpelesLab / libwallet / 27658322789

24%

Build Type

push

github

Committed by MagicalTux

Commit Message

wltwallet: bump tss-lib v2.2.9→v2.3.1 to match wdrone + wait full spot mesh + bump 0.4.63

Root cause for the field-reported FROST password reset failure
("failed to start remote peer ...: failed to init remote: context
deadline exceeded" / "wi PoK verification failed" against the live
wdrone fleet, captured locally as
TestReshare_FROST_StoreKeyPlusRemote_AsOldCommittee FAIL): tss-lib
version drift between libwallet (v2.2.9) and wdrone (v2.3.1).

v2.3.1 changed common.SHA512_256i_TAGGED to bind each big.Int
operand's sign — one extra 0x00/0x01 byte per operand, hashed
alongside the magnitude. This is a wire-incompatible hash change.
The two sides compute different Schnorr challenges c for the same
inputs:

  c_v2_3_1 = SHA512_256i_TAGGED(tag, X.X|0, X.Y|0, g.X|0, g.Y|0, ...)
  c_v2_2_9 = SHA512_256i_TAGGED(tag, X.X,   X.Y,   g.X,   g.Y,   ...)

wdrone (sender) builds the PoK against c_v2_3_1; libwallet's new
committee verifies with c_v2_2_9. alpha = t*G - c_sender*Vi0 holds;
alpha != t*G - c_verifier*Vi0 fails by exactly the c-X difference,
so verification rejects. The Schnorr proof passed wdrone's own
selfVerify (using v2.3.1 on both sides) — that telemetry was the
final tell.

Investigation surface ruled out one-by-one before landing here:
  - frosttss.Key JSON round-trip lossy (TestFrostShareJSONRoundTrip)
    — byte-identical, fine.
  - Full encrypt+CBOR bottle round-trip lossy
    (TestFrostShareFullBottleRoundTrip) — byte-identical, fine.
  - PartyID JSON round-trip lossy (TestPartyIDJSONRoundTrip) —
    fine.
  - PoK cofactor leak (TestFrostVi0InPrimeOrder) — Vi0 in
    prime-order subgroup.
  - PartyID drift on the wire (reshare-diag logging in
    libwallet+wdrone) — bit-identical sender_key_int both sides.
  - Wdrone-side wi/Vi0 inconsistency (selfVerifyPoK in wdrone) —
    ok=true; broadcast values internally consistent.

The diagnostic logging that surfaced the drift is reverted in this
commit (returned reshare.go + broker.go to their pre-... (continued)

Coverage Stats

18 of 23 new or added lines in 1 file covered. (78.26%)

15 existing lines in 3 files now uncovered.

4496 of 18763 relevant lines covered (23.96%)

101.22 hits per line