Freegle / Iznik / 22301

71%

Build Type

push

circleci

Committed by web-flow

Commit Message

fix(events): event digest images never render (invented user-site route) (#821)

Community-event digest emails built image URLs as
{userSite}/communityevent/{id}/image/{imgid} when the image had no
external URL. That is not a real route on the user site, so it 404s in
every client and the event photo never renders.

Fix EventsDigestService to resolve images the way volunteering (and V1)
already do:
 - externalmods.url present -> use it as-is (externally hosted);
 - externaluid is a TUS upload (freegletusd-) -> route the raw file
   through the delivery/resize proxy (?url=...&w=400);
 - otherwise -> the image domain's community-event thumbnail route
   {imagesDomain}/tcimg_{imgid}.jpg, which maps to
   /api/image?id=X&communityevent=1 and serves the stored image.

Verified the image-domain route returns a real JPEG for the reported
image (images.ilovefreegle.org/tcimg_48488.jpg -> 200 image/jpeg);
the old user-site route returns 404.

Volunteering was checked too (user asked): it already uses the correct
image-domain route (toimg_) and the delivery proxy, so it is unaffected.

Tests: add coverage for the local-image case (must be the tcimg_ image
route, never a /communityevent/ path) and the TUS case. Full
EventsDigestCommandTest run is green (27 passed).

Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>

Coverage Stats

11012 of 14630 branches covered (75.27%)

Branch coverage included in aggregate %.

12 of 13 new or added lines in 1 file covered. (92.31%)

14 existing lines in 3 files now uncovered.

119066 of 169007 relevant lines covered (70.45%)

36.29 hits per line