lsm / neokai / 27805081806

82%

Build Type

push

github

Committed by web-flow

Commit Message

feat(github-events): store PAT in keychain + add token/polling config UI (#2121)

* feat(github-events): store PAT in keychain + add token/polling config UI

External GitHub event source previously read the PAT only from
GITHUB_TOKEN, so non-shell users could not configure webhooks or
polling without daemon host access.

- Inject the shared CredentialStore into GitHubEventExtension; the
  extension now resolves the token from the keychain first and falls
  back to the env var. All GitHub API calls (autoConfigureWebhook,
  checkWebhook, deleteRemoteWebhook, githubFetch, pollWatchedRepo)
  run through resolveToken().
- Add RPC handlers space.github.setToken / getTokenStatus /
  clearToken so the UI can manage the PAT. getTokenStatus validates
  the token against /user and reports source (keychain vs env) plus
  login.
- Add RPC handler space.github.setPollingEnabled that flips the global
  polling capability, updates every watched repo in the space, and
  starts/stops the poll timer accordingly. watchRepo now auto-starts
  polling when the first polling-enabled repo is added; runPollCycle
  releases the timer once no polling repos remain.
- Expose ProviderCredentialManager.getCredentialStore() so the
  extension shares Keychain status tracking with provider credentials.
- Render a "GitHub connection" card in SpaceExternalEventsSettings
  with token input, disconnect button, and a per-space polling toggle.

* fix(github-events): address review (P1-P3) on token RPC + UI

Review: https://github.com/lsm/neokai/pull/2121#pullrequestreview-4510973422

P1 — daemon-wide token scope made explicit:
- Docstrings on setToken/clearToken call out daemon-wide blast radius
  and the intentional lack of per-space isolation.
- UI copy ("daemon-wide personal access token… shared by every space")
  reflects scope; connected view gains a "Replace token" affordance
  that, together with the Disconnect button, gates every overwrite
  behind a window.confirm() prompt.

P2 — se... (continued)

Coverage Stats

10812 of 15739 branches covered (68.7%)

Branch coverage included in aggregate %.

347 of 360 new or added lines in 5 files covered. (96.39%)

5 existing lines in 1 file now uncovered.

91893 of 109832 relevant lines covered (83.67%)

298.04 hits per line