openvax / datacache / 27785449947

79%

master: 79%

Build Type

Pull #56

github

Committed by iskandr

Commit Message

Decompress atomically (sibling temp + move) so corrupt archives leave no partial

Self-review of the prior hardening commit: streaming the zip member / gunzip
straight into full_path regressed atomicity. A corrupt or truncated archive
(e.g. a gzip CRC failure, detected only at end-of-stream) would leave a partial
file at full_path — and fetch_file treats "path exists" as a cache hit, so the
next call would silently serve the truncated data.

Add _decompress_to_file(): stream the decompressed source into a sibling temp,
then move it into place (matching the atomic `move` the non-decompress path
already uses); drop the partial on failure. Restores the atomicity the original
zip (extract+move) and gz (read-all-then-write) paths had, while keeping the
streaming (bounded-memory) behaviour.

Adds test_corrupt_gz_leaves_no_partial_cache locking it in.

Pull Request Pull Request #56: Make test_download.py hermetic; remove dead wget path; harden zip/gz decompress (closes #42)

Coverage Stats

23 of 0 new or added lines in 0 files covered. (NaN%)

1 existing line in 1 file now uncovered.

347 of 439 relevant lines covered (79.04%)

2.37 hits per line