openvax / datacache / 27785156915

79%

master: 79%

Build Type

Pull #56

github

Committed by iskandr

Commit Message

Harden zip/gz decompression; add zip test + tighten deprecation test

Addressing review of #42:
- Stream the chosen zip member straight to the destination via z.open() +
  copyfileobj, replacing ZipFile.extract() which wrote into the current working
  directory and recreated the member's stored path (cwd-pollution + a "../"
  path-traversal footgun). Member selection (named match, else biggest) is
  unchanged.
- Stream the gunzip to disk instead of reading the whole decompressed file into
  memory — consistent with the streaming download goal (#49).
- Add a .zip decompression test (previously only .gz was covered) that also
  asserts nothing leaks into the cwd, and pin the deprecation warning message
  with pytest.warns(match=...).

Pull Request Pull Request #56: Make test_download.py hermetic; remove dead wget path; harden zip/gz decompress (closes #42)

Coverage Stats

13 of 0 new or added lines in 0 files covered. (NaN%)

1 existing line in 1 file now uncovered.

337 of 429 relevant lines covered (78.55%)

2.35 hits per line