openvax / datacache / 27784677148

79%

master: 79%

Build Type

Pull #56

github

Committed by iskandr

Commit Message

Make test_download.py hermetic; remove dead wget download path (closes #42)

test_fetch_decompress hit a live Ensembl FTP server and looped over
use_wget_if_available/timeout while the file was only downloaded once — so the
result depended on iteration order (the flakiness in #42), and CI was noisy.

- Rewrite the tests to serve a local .gz over file:// with the cache redirected
  to a tmp dir (the pattern test_streaming_download.py already uses): no network,
  no cross-run cached state. Adds deterministic cache-reuse + force coverage.
- Remove the wget download path: subprocess.call's non-zero exit was ignored
  (silent partial downloads), and the modernization's streaming Python
  downloader (_stream_to_file, #49) already handles http(s) and ftp. Drops the
  subprocess/errno imports and the wget threading through the private helpers.
- Keep use_wget_if_available on the public fetch_file / Cache.fetch as a
  deprecated, ignored no-op (warns when explicitly passed) so callers don't break.

No version bump — leaving the release/version decision to the maintainer.

Pull Request Pull Request #56: Make test_download.py hermetic; remove dead wget path (closes #42)

Coverage Stats

22 of 25 new or added lines in 2 files covered. (88.0%)

26 existing lines in 1 file now uncovered.

331 of 438 relevant lines covered (75.57%)

2.26 hits per line