ultimate-notion / ultimate-notion / 27778111238

87%

push

github

Drop metaclass type: ignore by moving to_list onto OptionNSType (#206)

The `OptionNSType.__len__` metaclass method annotated its receiver as
`cls: type[OptionNS]` so the body could call `cls.to_list()`, but mypy
requires the receiver to be a supertype of the containing class (the
metaclass itself), producing a `[misc]` "Self argument missing" error
that was suppressed with a `type: ignore`.

`__len__` and `to_list` both operate on the namespace class itself, not
on instances, so they belong on the metaclass. Moving `to_list` from a
`@classmethod` on `OptionNS` onto `OptionNSType` lets mypy infer `cls`
as the metaclass instance and resolve `to_list` without the ignore, the
inaccurate `cls` annotation, or the outdated ToDo. Public behaviour
(`MyOptions.to_list()`, `len(MyOptions)`) is unchanged.

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

3 of 3 new or added lines in 1 file covered. (100.0%)

6520 of 7403 relevant lines covered (88.07%)

6.14 hits per line