ultimate-notion / ultimate-notion / 27776236680

87%

push

github

Type TypedObject.type as str | None to drop bare type: ignore (#205)

The `type` field on `TypedObject` carried a bare `# type: ignore` masking
an `[assignment]` error: `None` is not assignable to `str`. The annotation
was inaccurate — the field is `None` on the abstract polymorphic base and a
real `str` on concrete subclasses (set via `_set_field_default` in
`_register_type`). Annotating it `str | None` reflects the actual runtime
values, mirroring the earlier fix for the sibling `object` field (#204).

A new `_type_name` property narrows `str | None` to `str` for the call sites
that index by the type name, raising a clear `ValueError` if it is unexpectedly
`None` (which never happens on a concrete instance) instead of the previous
opaque `getattr(self, None)` `TypeError`. It is used in `value`/`value.setter`,
`BlocksEndpoint.update`, `Property.prop_value`, `Mention.type`, and
`Formula.value_type`.

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

13 of 15 new or added lines in 5 files covered. (86.67%)

6521 of 7404 relevant lines covered (88.07%)

6.14 hits per line