IntelPython / dpnp / 27760340703

78%

push

github

Return unitary vh from `dpnp.linalg.svd` for singular Hermitian inputs (#2954)

`dpnp.linalg.svd(..., hermitian=True)` could return a non-unitary `vh`
when the input array is singular. In the Hermitian path, the sign of
each eigenvalue is factored out of the eigenvectors into `vh`. The sign
was computed with `dpnp.sign(s)`, which returns `0` for zero
eigenvalues, zeroing out the corresponding rows of `vh` and breaking
unitarity.

The fix replaces `dpnp.sign(s)` with `dpnp.copysign(1.0, s)`, which
always yields ±1, mirroring the change included into NumPy 2.5.

1532 of 2854 branches covered (53.68%)

Branch coverage included in aggregate %.

1 of 1 new or added line in 1 file covered. (100.0%)

25975 of 32370 relevant lines covered (80.24%)

8022.45 hits per line