Freegle / Iznik / 22075

71%

Build Type

push

circleci

Committed by web-flow

Commit Message

fix(batch): retry Discourse rate-limits in DiscourseClient so the not-signed-up report isn't inflated (#797)

discourse:not-signed-up resolves each Discourse user's MT external_id via the
admin API (getUser) to decide which Freegle groups are represented by an active
mod. V1 (Utils::curlWithRetry + the GetUser/GetAllUsers/GetUserEmail error
checks) retried on rate-limiting (HTTP 429, or an "errors" body containing "too
many") up to 60× with a 1s delay, and threw on any other error response — so the
run aborted loudly rather than emailing a report built on partially-resolved
users.

The Laravel port did neither: `(array) ...->json()` with no retry and no error
check. A 429 silently became a body with no single_sign_on_record, so
getUser returned no external_id, the mod looked absent from Discourse, and every
group they cover was falsely flagged NOT REPRESENTED (and the mod listed under
"volunteers not on Discourse"). With ~410 users each needing a getUser call
against the rate-limited admin endpoint, partial 429s inflate the report
unpredictably.

Restore V1 behaviour: a single getJson() chokepoint retries on rate-limiting
(429 / "too many"), throws after max_retries, and throws on any other error or
non-JSON response. getAllUsers/getUser/getUserEmail all route through it.
Retry policy is configurable (freegle.discourse.max_retries / retry_delay_s,
defaulting to V1's 60 / 1s; throttle_us now explicit too).

Co-authored-by: root <root@localhost>
Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Coverage Stats

11009 of 14617 branches covered (75.32%)

Branch coverage included in aggregate %.

25 of 28 new or added lines in 1 file covered. (89.29%)

36 existing lines in 2 files now uncovered.

119105 of 169036 relevant lines covered (70.46%)

36.26 hits per line