dangernoodle-io / breadboard / 27732838344

100%

push

github

fix: use-after-free of MQTT handle in bb_sink_mqtt across OTA suspend/resume (B1-296) (#460)

- add bb_sink_mqtt_default() that resolves bb_mqtt_default() at publish
  time instead of capturing the handle pointer at boot; a NULL handle
  during the suspend window returns BB_ERR_INVALID_ARG (clean no-op,
  no crash) and the post-resume fresh handle is used automatically
- update bb_mqtt_telemetry_host.c winner path to register the dynamic
  sink; replace the now-false "handle is stable for device lifetime
  (B1-289)" comment with an accurate B1-296 note
- fix stale HANDLE STABILITY CONTRACT comment in bb_mqtt_espidf.c that
  described intended-but-unimplemented behavior; update to reflect the
  actual dynamic-resolution approach
- defense-in-depth (Fix C): guard bb_mqtt_publish in bb_mqtt_espidf.c
  under h->lock, check h->destroyed / h->client == NULL, capture client
  pointer locally, release lock before blocking publish call
- add five regression tests covering: dynamic sink routes to live handle,
  suspend is a safe no-op (non-crash), resume routes to the new handle
  and never the old freed one

Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>

1618 of 1618 branches covered (100.0%)

Branch coverage included in aggregate %.

2714 of 2714 relevant lines covered (100.0%)

1208.58 hits per line