lsm / neokai / 27729989034

82%

Build Type

push

github

Committed by web-flow

Commit Message

fix(space): codex bot login matcher + cycle-anchored gate timeout (#2120)

* fix(space): harden codex review bot gate (login matcher + cycle-anchored timeout)

Codex approval gates were blocking PRs on this repo because the matcher only
recognized `codex[bot]`, while GitHub's actual login is
`chatgpt-codex-connector[bot]`. The 600s timeout also fired before Codex
finished large-PR reviews (20–30 min), and was anchored to gate-data
`updated_at`, so any metadata write (e.g. persisting `head_sha`) silently
reset the wait window.

- Matcher: case-insensitive substring `test("codex"; "i")` so every Codex
  bot variant (codex[bot], chatgpt-codex-connector[bot], and future renames)
  is recognized without further code changes.
- Timeout: default raised 600s -> 7200s; anchored to `cycle_start_at`
  (set on init and every cyclic reset) so metadata writes no longer reset
  the window. Legacy gate-data predating `cycle_start_at` falls back to
  `updated_at`; workflow start remains a freshness-only fallback, never a
  timeout anchor.
- Configurability: global override via `NEOKAI_CODEX_REVIEW_BOT_TIMEOUT_SECONDS`
  env var; per-node override via new `WorkflowNode.codexTimeoutSeconds`
  (mirrors the existing `codexPollIntervalMs` plumbing — types, repository
  JSON config, RPC handlers, export/import zod schema, template hash,
  validator, structural merge).

Tests: matcher accepts an unknown variant, timeout anchored to
cycle_start_at fires even when updated_at is fresh, 2-hour window does not
expire at 10 minutes, per-node override substitutes the timeout value.

* fix(space): apply codex matcher + 2h timeout to migration scripts and reviewer prompts

Review feedback (PR #2120): the gate-features.ts matcher + timeout fix left
two parallel code paths stale.

- workflow-migration.ts: plan-approval and review-approval migration scripts
  still baked the explicit `codex[bot] OR chatgpt-codex-connector[bot]` list.
  Swap to `test("codex"; "i")` so legacy Spaces migra... (continued)

Coverage Stats

10723 of 15627 branches covered (68.62%)

Branch coverage included in aggregate %.

412 of 423 new or added lines in 9 files covered. (97.4%)

73 existing lines in 5 files now uncovered.

91376 of 109366 relevant lines covered (83.55%)

275.93 hits per line