Hyshmily / hotkey / 27728804845

87%

push

github

fix: broken @ConditionalOnClass annotation prevents HotKeyCache bean creation

@ConditionalOnClass(name = "io/github/hyshmily/hotkey/hotkeydetector")
used resource-path format (/), which Class.forName() can never resolve,
making the condition always false. Changed to type-safe
@ConditionalOnClass(HotKeyDetector.class).

Root cause of 41 integration-test errors + 5 benchmark failures:
HotKeyCache bean was never created when Redis was available because:
1) HotKeyAutoConfiguration.hotKeyCache() was skipped
   (@ConditionalOnMissingBean type=RedisTemplate)
2) HotKeyRedisAutoConfiguration.hotKeyCache() condition never matched
   (broken @ConditionalOnClass)
-> HotKey.requireCache() threw UnsupportedOperationException on every call.

Signed-off-by: Hyshmily <cxm8607@outlook.com>

703 of 1048 branches covered (67.08%)

Branch coverage included in aggregate %.

1952 of 2681 relevant lines covered (72.81%)

3.31 hits per line