IJHack / QtPass / 27723172503

55%

Build Type

push

github

Committed by web-flow

Commit Message

refactor(#1511): fold QtPass::init() fresh-install writes into AppSettings (#1566)

* refactor(#1511): fold QtPass::init() fresh-install writes into AppSettings (#1566)

The version.isEmpty() block in QtPass::init() already held a snapshot
(const AppSettings s) then wrote four fields back via individual setters.
Convert it to modify the snapshot in-place and call save() once; convert
the else branch to read s.passTemplate directly instead of via the getter.
Delete all five now-dead wrappers: setAutoclearSeconds,
setAutoclearPanelSeconds, setUsePwgen, getPassTemplate, setPassTemplate.

Update test callers:
- tst_settings.cpp: remove void (*setter)(const int &) from IntSetting
  struct and intSettings[] entries; update intRoundTrip() to use the
  load → modify field → save pattern (matching the bool/string round-trip
  tests from PR #1563)
- tst_util.cpp: replace two SettingGuard<bool, setUsePwgen> usages with
  inline RestoreUsePwgen RAII structs + explicit load→modify→save writes

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* refactor(tests): replace duplicated RestoreUsePwgen with AppSettingsGuard<T,Field>

The two RestoreUsePwgen structs in generateRandomPassword and boundedRandom
were verbatim copies. Add AppSettingsGuard<T, T AppSettings::*Field> alongside
the existing SettingGuard<T, Setter> in tst_util's class body, then reduce
each block to a single declaration line — the same style as the old
SettingGuard usage.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

---------

Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>

Coverage Stats

2 of 12 new or added lines in 1 file covered. (16.67%)

3 existing lines in 2 files now uncovered.

3672 of 6670 relevant lines covered (55.05%)

29.41 hits per line