lsm / neokai / 27716672778

82%

Build Type

push

github

Committed by web-flow

Commit Message

fix: stop persisting thinking_tokens deltas, persist api_retry messages (#2127)

* fix: stop persisting thinking_tokens deltas, persist api_retry messages

Part A - thinking_tokens leak fix:
- Stop persisting thinking_tokens deltas (transient live event only)
- Add state.thinkingProgress live event for real-time UI updates
- Stamp final estimate on assistant messages with thinking blocks
- Filter thinking_tokens from SQL read paths (MESSAGES_BY_SESSION_SQL, _getSDKMessagesImpl)
- Remove ThinkingTokensMessage component from frontend
- Show estimated token count on ThinkingBlock (survives reload)

Part B - api_retry visibility fix:
- Persist api_retry messages (removed early return)
- Add ApiRetryMessage component with attempt/delay/error display
- Allow api_retry through render gate (type-guards.ts)

This eliminates DB bloat from thinking_tokens deltas (dozens-to-hundreds
of rows per thinking turn) and provides user visibility into API retries.

* fix: wire thinkingProgress event subscription, reset estimate on idle

P1 - Wire state.thinkingProgress in SessionStore:
- Add thinkingProgress signal to track transient progress
- Subscribe to state.thinkingProgress events in startSubscriptions
- Clear signal on session switch
- This fixes the acceptance criterion "transient thinking progress visible"

P2 - Reset currentThinkingTokensEstimate on turn-end/idle:
- Reset field in handleSessionStateChangedMessage when state === 'idle'
- Prevents stale estimate leak across turns (turn A thinking_tokens → interrupt → idle → turn B gets stale estimate)
- Matches the pattern of other turn-scoped fields (usesSessionStateChangedTurnEnd, expectsSessionStateIdleAfterResult, lastResultWasSuccess)

* test: update 3 stale tests for thinking_tokens suppression

P1 - Fix 3 test regressions caused by thinking_tokens SQL filter:

Web tests (2):
- SDKMessageRenderer.test.tsx: Flip from asserting 'Thinking tokens' renders
  to verifying suppression (returns null)
- SubagentBlock... (continued)

Coverage Stats

27 of 27 new or added lines in 5 files covered. (100.0%)

1 existing line in 1 file now uncovered.

50324 of 58858 relevant lines covered (85.5%)

542.19 hits per line