IJHack / QtPass / 27713458196

55%

Build Type

push

github

Committed by web-flow

Commit Message

refactor(#1511): snapshot AppSettings in MainWindow multi-field read sites (#1560)

* refactor(#1511): snapshot AppSettings in MainWindow multi-field read sites

Replace per-call QtPassSettings getter chains with a single load() snapshot
in each function that reads 2+ settings fields:

- Constructor: useMonospace, noLineWrapping, autoclearPanelSeconds
- applyTextBrowserSettings: useMonospace, noLineWrapping
- config() accepted block: passStore, autoclearPanelSeconds, useTrayIcon (×2)
- restoreWindow: maximized, alwaysOnTop, useTrayIcon (×2), startMinimized
- on_grepButton_toggled: usePass, passStore (×2)
- onGrepFinished: hideContent, useAutoclearPanel
- on_grepResultsList_itemClicked: passStore, hideContent, useAutoclearPanel
- passOtpHandler: useAutoclearPanel (consolidates existing load() call)
- setPassword: passStore (×2, reuses existing load() for PasswordDialog)
- addPassword: passStore (×4, local QString passStore)
- showContextMenu: passStore (×2), usePass, passExecutable, gpgExecutable
- addFolder: passStore (×3), addGPGId
- editPassword: useGit, autoPull
- exportPublicKey: passSigningKey, gpgExecutable
- updateGitButtonVisibility: useGit, gitExecutable, passExecutable

Single-field reads (isShowProcessOutput, isHideOnClose, isUseOtp, etc.)
retain their individual getters per the team convention established in #1559.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* fix: return after recursive config() to prevent stale AppSettings snapshot

After the inner config() call handles all post-accept setup, continuing
with the outer snapshot s would apply autoclearPanelSeconds, useTrayIcon,
etc. from before the recursive dialog. Add return to exit cleanly.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

---------

Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>

Coverage Stats

11 of 59 new or added lines in 1 file covered. (18.64%)

10 existing lines in 1 file now uncovered.

3964 of 6945 relevant lines covered (57.08%)

23.69 hits per line