freebsd / iocage / 27682514766

8%

push

github

Configure IPv6 correctly when IPv4 DHCP is enabled (#113)

* Fix IPv4 DHCP blocking static IPv6 address assignment in VNET jails

When dhcp=1 was set for IPv4, two places in the VNET startup code
incorrectly prevented IPv6 static addresses from being configured:

1. start_network_interface_vnet: The DHCP address-spoofing check
   iterated over both IPv4 and IPv6 net_configs, replacing static
   IPv6 addresses with empty strings. Add `not ipv6` guard so the
   spoofing only applies to IPv4 entries.

2. start_network_vnet_addr: The `wants_dhcp` flag (derived from
   IPv4 DHCP settings) gated all ifconfig calls, skipping the
   `ifconfig inet6` command for static IPv6. Change the condition
   to `(ipv6 or not wants_dhcp)` so IPv6 addresses are always
   assigned regardless of IPv4 DHCP state.

This allows the intended configuration of dynamic IPv4 via DHCP
with static IPv6 addresses to work correctly.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* Add regression tests for IPv4 DHCP / IPv6 static address interaction

Tests for start_network_vnet_addr cover:
- Static IPv6 assigned when IPv4 DHCP is enabled
- IPv4 ifconfig skipped when DHCP handles it
- Both address families assigned when DHCP is off
- accept_rtadv never triggers ifconfig
- DHCP keyword in ip4_addr string skips IPv4 but not IPv6

Tests for start_network_interface_vnet cover:
- IPv4 DHCP address spoofing does not affect IPv6 entries
- IPv4 addresses are correctly spoofed when DHCP is active
- Both addresses pass through unspoofed when DHCP is off

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

84 of 3275 branches covered (2.56%)

Branch coverage included in aggregate %.

2 of 2 new or added lines in 1 file covered. (100.0%)

829 of 7850 relevant lines covered (10.56%)

0.21 hits per line