tarantool / tarantool / 27681632657

88%

Build Type

push

github

Committed by sergepetrenko

Commit Message

applier: stop if snapshot fetch is interrupted

Before this patch, during the initial join stage, if the error was
retryable, the replica always attempted to reconnect. However, if the
replica already applied some rows, it sometimes concluded that it had
already applied the whole snapshot, although it did not.

This patch solves that issue by adding a corresponding check to the error
handling in applier_f. If error occurred during APPLIER_FETCH_SNAPSHOT
phase and the applier has already applied some rows, the applier stops,
because we cannot be sure if we have all the data.

This patch also drops second part of the gh-5566-final-join-synchro test,
because we can't safely retry the replica registration stage if it was
interrupted, but second part of this test attempts to do so.
Corresponding ticket: #12431.

Closes #10737

NO_DOC=bugfix
NO_CHANGELOG=bugfix

Coverage Stats

70715 of 118902 branches covered (59.47%)

5 of 5 new or added lines in 1 file covered. (100.0%)

144 existing lines in 14 files now uncovered.

106408 of 121357 relevant lines covered (87.68%)

1372287.8 hits per line