decentraland / marketplace / 27662644409

65%

master: 65%

push

github

fix: hide social emote detail pages and stop collection-items refetch loop (#2652)

* fix: hide social emote detail pages and stop collection-items refetch loop

When a social emote is opened directly (e.g. /contracts/<addr>/items/2)
while the feature is hidden, the detail page still rendered it and its
collection widget retried the /v1/items request indefinitely.

- AssetProviderPage: treat a social emote as not found when the
  SOCIAL_EMOTES feature is disabled, so the detail page (and the collection
  widget it mounts) does not render.
- CollectionProvider: request collection items at most once per collection
  instead of refetching whenever items.length !== collection.size, which
  looped forever when fewer items came back than the collection size (e.g.
  social emotes are filtered out of the response).

* refactor: address PR review feedback for social emote hiding

- CollectionProvider: bound the collection-items request to a small number
  of attempts per collection instead of a single hard guard, so a transient
  fetch error can still be retried once while the count-mismatch loop (fewer
  items than collection.size, e.g. social emotes filtered out) stays bounded.
- AssetProviderPage: defensive optional chaining on the asset data.
- Add unit tests for CollectionProvider (request bounding / no loop) and
  AssetProviderPage (social emote treated as not found only when the feature
  is disabled).

3670 of 7253 branches covered (50.6%)

Branch coverage included in aggregate %.

9 of 9 new or added lines in 2 files covered. (100.0%)

8565 of 11582 relevant lines covered (73.95%)

97.04 hits per line