decentraland / marketplace / 27661041984

65%

master: 65%

Build Type

Pull #2652

github

Committed by LautaroPetaccio

Commit Message

fix: hide social emote detail pages and stop collection-items refetch loop

When a social emote is opened directly (e.g. /contracts/<addr>/items/2)
while the feature is hidden, the detail page still rendered it and its
collection widget retried the /v1/items request indefinitely.

- AssetProviderPage: treat a social emote as not found when the
  SOCIAL_EMOTES feature is disabled, so the detail page (and the collection
  widget it mounts) does not render.
- CollectionProvider: request collection items at most once per collection
  instead of refetching whenever items.length !== collection.size, which
  looped forever when fewer items came back than the collection size (e.g.
  social emotes are filtered out of the response).

Pull Request Pull Request #2652: fix: hide social emote detail pages and stop collection-items refetch loop

Coverage Stats

3639 of 7223 branches covered (50.38%)

Branch coverage included in aggregate %.

3 of 4 new or added lines in 1 file covered. (75.0%)

1 existing line in 1 file now uncovered.

8544 of 11562 relevant lines covered (73.9%)

97.24 hits per line