BCDA-APS / 3idc-bits / 27641502809

56%

Build Type

push

github

Committed by prjemian

Commit Message

flyscan: split post-stub block into three independent try blocks

The post-wait_writer_plan_stub block used one big try wrapping all
three master-file write steps.  A failure in any step (commonly
the third, the VirtualLayout open of the external AD HDF1 file)
masked the success of the others and emitted a generic 'failed to
write per-frame positions' warning regardless of which step
actually failed.

Restructure into three independent steps:

  Step 1 of 3: /entry/images external link.
  Step 2 of 3: /entry/positions per-frame correlation block.
  Step 3 of 3: /entry/flyscan_data NXdata + VirtualLayout into the
               external AD HDF1 file.

Each step has its own try; each warning identifies the specific
failing step.  Step 2 sets df=None on failure so step 3 is skipped
cleanly.

Two openability gates use the _wait_for_openable helper:

  Loop A (before step 1): master file openable for append?  If
  not (writer-thread race), log an error and abandon the whole
  post-stub block.

  Loop B (before step 3): external AD HDF1 file openable for
  read?  If not (missing ad_files symlink, unmounted NFS), log
  an error and skip just step 3; steps 1 and 2 have already
  succeeded and the master file is otherwise intact.

Also: replace the inline external-link target construction with
the new _external_link_target helper (commit b7a204b), and call
_check_ad_files_symlink to give the operator a clear, actionable
warning when the ad_files symlink they depend on is missing.

Coverage Stats

0 of 48 new or added lines in 1 file covered. (0.0%)

466 existing lines in 2 files now uncovered.

960 of 1909 relevant lines covered (50.29%)

0.5 hits per line