PrincetonUniversity / PsyNeuLink / 27626242743

84%

master: 85%

Build Type

Pull #3559

github

Committed by davidt0x

Commit Message

Warn when optuna study direction mismatches PEC direction

When an optuna Study is passed as the PECOptimizationFunction method, the
study's optimization direction is fixed at creation time and used as-is
(the study is not recreated). A mismatch with the direction PEC expects
silently optimizes the wrong way -- e.g. data fitting does maximum
likelihood estimation and requires direction='maximize'. Warn in that
case so the misconfiguration is visible.

Also fix the adjacent optuna_kwargs check: _optuna_kwargs is always a dict
(never None), so the "ignored" warning previously fired even when no
kwargs were passed; use a truthy check instead.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

Pull Request Pull Request #3559: feat(pec): allow passing an optuna Study to PECOptimizationFunction

Coverage Stats

11018 of 14384 branches covered (76.6%)

Branch coverage included in aggregate %.

9 of 10 new or added lines in 1 file covered. (90.0%)

2 existing lines in 1 file now uncovered.

37653 of 43557 relevant lines covered (86.45%)

0.86 hits per line