MushroomObserver / mushroom-observer / 27617798818

98%

main: 98%

Build Type

Pull #4547

github

Committed by nimmolo

Commit Message

fixups: address Copilot review on #4547 + add three controller tests

Three real findings from Copilot:

- `locations/search#show` (turbo_stream branch) was using
  `turbo_stream.update(:search_bar_help, html: render_to_string(...))`.
  The `html:` kwarg isn't accepted by Turbo's update builder, so the
  stream would emit an empty template. Match the existing
  `names/search#show` pattern: pass the Phlex view directly as the
  second positional arg.
- `support/donors` Phlex view declared `prop :donor_list,
  _Array(_Hash(String, String))`, but `Donation.donor_list` returns
  hashes with numeric / Time values (`total`, `most_recent`). The
  view only ever reads `donor["who"]`, so the prop is now
  `prop :donor_names, _Array(String)` and the controller maps the
  hash list down to the name array before constructing the view.
- `info/translators_note` was calling `Language.all.sort_by(&:order)`
  inside the Phlex view — an AR query in view code, blocked by
  `no_queries_in_phlex_views_test`. Moved to the controller; the view
  takes a typed `languages:` prop.

Coverage cleanup:

- Deleted two unreachable Phlex views (`info/letter_to_community.rb`,
  `info/risd_terminology.rb`). The ERBs they were converted from had
  no controller action or route; the rendering paths never existed.
- Added smoke tests for `info#translators_note` and
  `locations/help#show` — both were silently 0/total on coveralls.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Pull Request Pull Request #4547: controllers: ERB→Phlex sweep for licenses, publications, interests, support, theme, policy, info, locations

Coverage Stats

1099 of 1123 new or added lines in 64 files covered. (97.86%)

33 existing lines in 5 files now uncovered.

49029 of 50178 relevant lines covered (97.71%)

675.15 hits per line