MushroomObserver / mushroom-observer / 27614423117

98%

main: 98%

Build Type

push

github

Committed by nimmolo

Commit Message

controllers: ERB→Phlex sweep for licenses, publications, interests, support, theme, policy, info, locations

Converts ~38 ERB action templates / partials across eight controller areas to Phlex view classes under `app/views/controllers/`. Each controller's implicit `render(:action)` is replaced with an explicit `render(Views::Controllers::<Area>::<Action>.new(...))`. The Phlex 2.4 prop contracts surface what each page actually consumes.

Highlights:

- locations/index moves the per-location observation count from inside the view (where it had been running an aggregated AR query) to a controller-side `known_observation_counts` helper, mirroring the existing `attach_undef_counts` shape used for the undefined-locations panel. The count is passed in as a typed `observation_counts` prop.
- theme: HTML was being built in `ThemeController` via `view_context.link_to(...).html_safe`. Pushed all of that into a new `Views::Controllers::Theme::SpeciesParagraph` Phlex view, with a `SpeciesRow` Data PORO replacing the raw Array tuples. The controller goes back to one-liner renders.
- `Components::Base` includes `Phlex::Rails::Helpers::NumberWithPrecision` so every Phlex view/component gets `number_with_precision` for free (used by donate-confirm amount formatting).
- `Components::Table` block arg renamed `tbl` (was `tab`) — `tab` collides with the `Tab::*` PORO concept.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Coverage Stats

1037 of 1367 new or added lines in 66 files covered. (75.86%)

33 existing lines in 5 files now uncovered.

48967 of 50422 relevant lines covered (97.11%)

669.26 hits per line