• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

Azure / ARO-RP / 27609736022
39%

Build:
DEFAULT BRANCH: master
Ran 16 Jun 2026 10:01AM UTC
Jobs 6
Files 972
Run time 3min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

16 Jun 2026 10:00AM UTC coverage: 39.01% (+0.02%) from 38.988%
27609736022

push

github

web-flow
[Critical] fix(monitor): tighten timeout cleanup and close idle connections (#4882)

* fix(monitor): close cluster monitor idle connections

Make cluster monitors retain the shared Kubernetes HTTP client so the monitor
can close idle connections after each cycle instead of leaking transport state.

Co-authored-by: Cursor <cursoragent@cursor.com>

* fix(monitor): bound worker cleanup after timeouts

Let timed out monitor cycles wait briefly for in-flight goroutines and then
close closeable monitors so transport-backed workers do not linger indefinitely.

Co-authored-by: Cursor <cursoragent@cursor.com>

* fix(monitor): close aro client idle connections

Close the ARO typed client's idle HTTP connections when cluster monitors are disposed so the goroutine cleanup change also covers the separate arocli transport. Add targeted tests for the real close path and the fake clientset nil REST client guard.

Co-authored-by: Cursor <cursoragent@cursor.com>

* test(monitor): align cleanup test with package style

Use the standard library panic check in the fake ARO client cleanup test and document the typed-nil REST client guard so the cleanup path stays consistent with nearby monitor tests.

Co-authored-by: Cursor <cursoragent@cursor.com>

* docs(monitor): clarify closeable cleanup contract

Document that Closeable implementations must tolerate forced cleanup before
Monitor returns, including concurrent and repeated Close calls.

Co-authored-by: Cursor <cursoragent@cursor.com>

* fix(monitor): distinguish timeout from cancellation in workOne

Differentiate context.DeadlineExceeded from parent context cancellation
so the timeout metric and log message are only emitted on actual
timeouts, not on graceful shutdown.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

36 of 46 new or added lines in 2 files covered. (78.26%)

5 existing lines in 1 file now uncovered.

30376 of 77868 relevant lines covered (39.01%)

0.44 hits per line

Uncovered Changes

Lines Coverage ∆ File
8
46.5
2.06% pkg/monitor/cluster/cluster.go
2
85.29
1.81% pkg/monitor/worker.go

Coverage Regressions

Lines Coverage ∆ File
5
93.94
-0.67% pkg/frontend/admin_openshiftcluster_runjob.go
Jobs
ID Job ID Ran Files Coverage
1 pkg-util - 27609736022.1 16 Jun 2026 10:04AM UTC 317
20.69
GitHub Action Run
2 pkg-frontend - 27609736022.2 16 Jun 2026 10:04AM UTC 105
75.64
GitHub Action Run
3 pkg-operator - 27609736022.3 16 Jun 2026 10:04AM UTC 76
48.55
GitHub Action Run
4 pkg-api - 27609736022.4 16 Jun 2026 10:01AM UTC 163
65.8
GitHub Action Run
5 cmd - 27609736022.5 16 Jun 2026 10:04AM UTC 13
0.0
GitHub Action Run
6 pkg-other - 27609736022.6 16 Jun 2026 10:05AM UTC 298
32.88
GitHub Action Run
Source Files on build 27609736022
  • Tree
  • List 972
  • Changed 4
  • Source Changed 3
  • Coverage Changed 3
Coverage ∆ File Lines Relevant Covered Missed Hits/Line
  • Back to Repo
  • Github Actions Build #27609736022
  • 1ec4df63 on github
  • Prev Build on master (#27609419751)
  • Next Build on master (#27629511461)
  • Delete
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc