Azure / ARO-RP / 27609419751

39%

Build Type

push

github

Committed by web-flow

Commit Message

feat: add rollback recovery for control plane resize (#4865)

* feat(frontend): add rollback recovery for control plane resize

Add automatic rollback to /resizecontrolplane so failed master resizes restore the cluster to a healthy state with three running, schedulable control plane nodes at matching SKUs.

Key behaviors:
- Per-node snapshot captures original VM size, Machine spec, Node labels, and schedulability before mutation
- On failure, nodes roll back in reverse order and restore VM size, Machine metadata, Node labels, and schedulability
- Etcd health is checked between each node resize in forward and rollback paths
- Context detachment lets the operation complete even if the admin HTTP connection drops
- Step journaling captures forward and rollback timing details for diagnostics

Fixes ARO-27429

* fix(frontend): reduce rollback PR scope and harden rollback gate

Keep rollback-specific logic in this PR by dropping pre-validation inventory carryover and duplicated rollback matrix tests, while making rollback stop when etcd is unhealthy between nodes and documenting the behavior.

* fix(frontend): guard resize error normalization and immediate retry cancellation

Prevent nil CloudErrorBody panics when normalizing wrapped resize errors and stop zero-delay retry loops from issuing extra Azure calls after context cancellation.

Co-authored-by: Cursor <cursoragent@cursor.com>

* test(frontend): keep default-delay retry semantics

Revert the zero-delay cancellation behavior change and its extra test to keep runtime semantics aligned with the existing production retry policy.

Co-authored-by: Cursor <cursoragent@cursor.com>

* refactor(frontend): simplify control plane node label updates

Keep rollback label restoration on the same aligned-label path used during resize so the helper surface matches the fail-closed validation model.

Co-authored-by: Cursor <cursoragent@cursor.com>

* refactor(frontend): remove rollback retry policy indirection

Keep t... (continued)

Coverage Stats

407 of 449 new or added lines in 4 files covered. (90.65%)

3 existing lines in 2 files now uncovered.

30344 of 77830 relevant lines covered (38.99%)

0.44 hits per line