• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

Azure / ARO-RP / 27609419751
39%

Build:
DEFAULT BRANCH: master
Ran 16 Jun 2026 09:56AM UTC
Jobs 6
Files 972
Run time 2min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

16 Jun 2026 09:55AM UTC coverage: 38.988% (+0.3%) from 38.697%
27609419751

push

github

web-flow
feat: add rollback recovery for control plane resize (#4865)

* feat(frontend): add rollback recovery for control plane resize

Add automatic rollback to /resizecontrolplane so failed master resizes restore the cluster to a healthy state with three running, schedulable control plane nodes at matching SKUs.

Key behaviors:
- Per-node snapshot captures original VM size, Machine spec, Node labels, and schedulability before mutation
- On failure, nodes roll back in reverse order and restore VM size, Machine metadata, Node labels, and schedulability
- Etcd health is checked between each node resize in forward and rollback paths
- Context detachment lets the operation complete even if the admin HTTP connection drops
- Step journaling captures forward and rollback timing details for diagnostics

Fixes ARO-27429

* fix(frontend): reduce rollback PR scope and harden rollback gate

Keep rollback-specific logic in this PR by dropping pre-validation inventory carryover and duplicated rollback matrix tests, while making rollback stop when etcd is unhealthy between nodes and documenting the behavior.

* fix(frontend): guard resize error normalization and immediate retry cancellation

Prevent nil CloudErrorBody panics when normalizing wrapped resize errors and stop zero-delay retry loops from issuing extra Azure calls after context cancellation.

Co-authored-by: Cursor <cursoragent@cursor.com>

* test(frontend): keep default-delay retry semantics

Revert the zero-delay cancellation behavior change and its extra test to keep runtime semantics aligned with the existing production retry policy.

Co-authored-by: Cursor <cursoragent@cursor.com>

* refactor(frontend): simplify control plane node label updates

Keep rollback label restoration on the same aligned-label path used during resize so the helper surface matches the fail-closed validation model.

Co-authored-by: Cursor <cursoragent@cursor.com>

* refactor(frontend): remove rollback retry policy indirection

Keep t... (continued)

407 of 449 new or added lines in 4 files covered. (90.65%)

3 existing lines in 2 files now uncovered.

30344 of 77830 relevant lines covered (38.99%)

0.44 hits per line

Uncovered Changes

Lines Coverage ∆ File
30
90.54
pkg/frontend/admin_openshiftcluster_resize_controlplane_recovery.go
7
34.72
34.72% pkg/frontend/admin_openshiftcluster_validatefullresize.go
5
83.91
2.09% pkg/frontend/admin_openshiftcluster_resize_controlplane.go

Coverage Regressions

Lines Coverage ∆ File
2
83.91
2.09% pkg/frontend/admin_openshiftcluster_resize_controlplane.go
1
34.72
34.72% pkg/frontend/admin_openshiftcluster_validatefullresize.go
Jobs
ID Job ID Ran Files Coverage
1 pkg-operator - 27609419751.1 16 Jun 2026 09:58AM UTC 76
48.55
GitHub Action Run
2 pkg-util - 27609419751.2 16 Jun 2026 09:58AM UTC 317
20.69
GitHub Action Run
3 pkg-other - 27609419751.3 16 Jun 2026 09:59AM UTC 298
32.81
GitHub Action Run
4 cmd - 27609419751.4 16 Jun 2026 09:59AM UTC 13
0.0
GitHub Action Run
5 pkg-frontend - 27609419751.5 16 Jun 2026 09:58AM UTC 105
75.66
GitHub Action Run
6 pkg-api - 27609419751.6 16 Jun 2026 09:56AM UTC 163
65.8
GitHub Action Run
Source Files on build 27609419751
  • Tree
  • List 972
  • Changed 6
  • Source Changed 3
  • Coverage Changed 6
Coverage ∆ File Lines Relevant Covered Missed Hits/Line
  • Back to Repo
  • Github Actions Build #27609419751
  • d78b4704 on github
  • Prev Build on master (#27583195065)
  • Next Build on master (#27609736022)
  • Delete
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc