kobotoolbox / kpi / 27607895937

82%

master: 76%

push

github

fix(reports): general color override doesn't work for single report with custom type DEV-2223 (#7118)

### 📣 Summary

Fixed report color behavior so chart colors update consistently across
chart types and still inherit global color changes after per-question
chart-type overrides.

### 💭 Notes

This PR resolves a reports styling issue where color updates could
behave inconsistently, especially after setting a single-question graph
type. It also refactors report rendering prep into utility helpers and
adds focused tests so this behavior is easier to maintain and less
likely to regress.

Changes here:
- Refactor row preparation and keep render focused on orchestration
- Add style inheritance and select-label helper utilities
- Fix chart-type-specific dataset color behavior and export props for
testability
- Remove unused report listeners
- Add reusable report test factories
- Add utility tests for style inheritance and label mapping
- Add chart rendering tests for color behavior by chart family

Key implementation details:
- Question-level style overrides are treated as partial and merged over
base/global style, so changing global colors still propagates unless
explicitly overridden.
- Dataset color assignment now respects chart-family needs:
  - line and area use single-color line/point styling
  - pie, donut, and polar use full palettes
  - radar keeps point palette behavior
- Render-time logic in reports is split into utility functions with
comments for maintainability and easier unit coverage.

Tiny AI joy for reviewers:
- We untangled the style spaghetti without losing the sauce.

### 👀 Preview steps

1. ℹ️ Have an account with permission to edit a deployed project that
has response data.
2. Go to Project → Data → Reports.
3. Open report settings and change global chart colors.
4. Open question settings for one question and change only its chart
type, then save.
5. 🔴 [on main] Observe that this question may stop reflecting later
global color changes... (continued)

9034 of 12268 branches covered (73.64%)

29662 of 36357 relevant lines covered (81.59%)

5.56 hits per line