MushroomObserver / mushroom-observer / 27601470154

98%

main: 98%

Pull #4546

github

location form: surface Google Maps geocode failures (#4535)

Issue #4535: clicking "Find on Map" on the location edit page appears
to do absolutely nothing. Root cause is in the Google Cloud Console,
not the codebase — the Geocoding API is disabled on the Maps API key
that the production site uses, so every geocode request comes back as
`REQUEST_DENIED: The webpage is not allowed to use the geocoder`. The
JS catch handler swallowed that error to `console.log`, so the user
saw nothing.

This PR makes the failure mode visible. Whoever owns the Google Cloud
project still needs to enable the Geocoding API on the key — that's
the actual fix for #4535. Without this change, the next time the key
or any other Google service flakes, "Find on Map" will silently break
the same way.

- `geocode_controller.js` — replace the silent `console.log` catches
  with `showGeocodeError(e)`, which renders a Bootstrap `.alert-danger`
  into `#geocode_flash` with the underlying error message.
- `Views::Controllers::Locations::Form` — render the `#geocode_flash`
  slot above the place input on the editable variant of the form.
- `Views::Controllers::Locations::FormTest` — assert the slot and the
  `data-map-target='placeInput'` data attribute the controller reads.

2 of 2 new or added lines in 1 file covered. (100.0%)

48031 of 49123 relevant lines covered (97.78%)

683.55 hits per line