RobotWebTools / rclnodejs / 27588532884

91%

push

github

[Windows] Fix native build failure on the VS 2026 toolset (#1539)

The `windows-2025` GitHub Actions runner provisions Visual Studio 2026 (v18) alongside VS 2022, and `gha-setup-vsdevenv` selects the newest install via `vswhere -latest`. The v18 `constexpr` evaluator crashes with an Internal Compiler Error (C1001) while instantiating node-addon-api's templated `InstanceAccessor<&Fn>()` helper (`napi-inl.h`), which takes the getter as a `constexpr` member-pointer template argument.

Replace the templated accessor with the equivalent runtime overload in `ref-napi`'s `PointerBuffer::Init`:

- `InstanceAccessor<&PointerBuffer::Length>("length")`
+ `InstanceAccessor("length", &PointerBuffer::Length, nullptr)`

The runtime overload passes the getter as a plain function pointer and the setter as `nullptr`, preserving the read-only `length` accessor exactly while avoiding the `constexpr` template path that trips the ICE. This compiles cleanly on every platform/toolset and is a no-op at runtime.

Fix: #1538

2043 of 2401 branches covered (85.09%)

Branch coverage included in aggregate %.

16688 of 18133 relevant lines covered (92.03%)

229.16 hits per line