agama-project / agama / 27557362244

83%

Build Type

push

github

Committed by web-flow

Commit Message

fix(web): configuration dialog improvements (#3631)

## Problem

During review meeting, two issues were found:

* Name for the downloaded file has the `.json` extension twice
* The `isReadOnly` PF/CodeEditor prop defined at
https://github.com/agama-project/agama/blob/master/web/src/components/core/ConfigDialog.tsx#L77
was not being honored

## Solution

Drop the filename extension since CodeEditor appends the extension
derived from its language prop and use the CodeEditor `options` and
`onEditorDidMount` props, which merge with PatternFly's defaults instead
of overriding them.

## Testing

- Updated unit tests
- Tested manually

Coverage Stats

4771 of 6682 branches covered (71.4%)

Branch coverage included in aggregate %.

2 of 3 new or added lines in 1 file covered. (66.67%)

1 existing line in 1 file now uncovered.

25071 of 29318 relevant lines covered (85.51%)

124.74 hits per line