agama-project / agama / 27556345635

83%

Build Type

push

github

Committed by web-flow

Commit Message

feature(web): split dock for Terminal (#3622)

> [!NOTE]
>
> This is a proof-of-concept for where the terminal should live in the
web UI, following up on the discussion in #3617. It docks the terminal
as a resizable panel at the bottom of the app, opened from the installer
menu, with show/hide, minimize/restore, and a "needs more space" state
on smaller screens. The terminal content is a mockup for now: the real
xterm.js session and its backend transport are out of scope here, the
focus is placement, layout, and interaction.
> 
> Find below the  reasoning, including why not a tab, popup, or drawer.

---

## Reconsidering my own comment

In my own comment at
https://github.com/agama-project/agama/pull/3617#issuecomment-4692789565
I argued to start simple: offer the terminal as a modal/popup the way
other tools do, doubted there would be much back-and-forth between the
terminal and the UI, and floated a "minimize" mechanism or an
always-available drawer only as possible later enhancements. Having
thought it through, I've changed my mind, both on the popup and on the
drawer, for the reasons I lay out below.

On the drawer specifically: it is a legitimate option ([PatternFly's own
Drawer
guidelines](https://www.patternfly.org/components/drawer/design-guidelines)
even list a terminal as a sample use case), but Agama doesn't use
drawers today, and if the UI evolves in that direction I can see them
being valuable for workflows closer to the web UI's core purpose
(details, previews, edit views beside the main content). That makes the
drawer a space worth keeping free, especially since drawers could not
compose well when several features want one at once. Spending it on
terminal access now would likely be a shot in the foot tomorrow, when a
workflow better suited to it comes along. So I'd rather find the
terminal a home that doesn't take that space.

## The case for a split

@lslezak makes a good point in #3617: when users use the terminal they
could switch be... (continued)

Coverage Stats

4771 of 6682 branches covered (71.4%)

Branch coverage included in aggregate %.

121 of 148 new or added lines in 9 files covered. (81.76%)

28 existing lines in 3 files now uncovered.

25069 of 29316 relevant lines covered (85.51%)

124.74 hits per line