blues / note-c / 27548380112

93%

push

github

build: add reusable CMake library target for downstream projects (#236)

* build: Add macOS build support for unit tests

Add conditional CMake configuration for macOS (APPLE):
- Skip -m32 and Linux-specific linker flags
- Define HAVE_STRLCPY/HAVE_STRLCAT (macOS provides these natively)
- Exclude n_str.c (strlcpy/strlcat bundled implementations)
- Suppress AppleClang-specific warnings in upstream code
- Use -flat_namespace for dylib and test executables to enable
FFF test fake symbol interposition

All changes are guarded by if(APPLE)/if(NOT APPLE) so Linux CI behavior is completely unchanged.

* build: Add macOS build support for unit tests

Use check_symbol_exists() to detect system-provided strlcpy/strlcat (macOS, *BSD) and conditionally exclude n_str.c and define HAVE_STRLCPY/ HAVE_STRLCAT guards. This avoids collisions with the platform's fortified string macros that prevented compilation on macOS.

Guard the 32-bit x86 compile/link flags behind a Linux x86 check instead of if(NOT APPLE), making the build portable to any non-x86 platform.

Suppress two AppleClang warnings-as-errors in upstream code (-Wstrict-prototypes, -Wunused-but-set-variable).

Add -Wl,-flat_namespace on macOS for both the library and test executables so FFF test fakes can interpose dylib symbols.

* fix: Resolve AppleClang warnings-as-errors

- n_ua.c: add void to NoteUserAgent() prototype to fix
-Wstrict-prototypes (empty parens means unspecified args in C)
- n_helpers.c: remove unused variables j and lastLengthCount that
triggered -Wunused-but-set-variable

With these fixes the -Wno-* suppressions added in the previous commit are no longer needed and are removed from CMakeLists.txt.

* ci: Add macOS build verification job to CI pipeline

Adds a `run_macos_unit_tests` job that configures and builds note-c with tests on macos-latest. Tests are not run via ctest because FFF symbol interposition does not fully work on macOS — even with -flat_namespace, intra-library calls are ... (continued)

1197 of 1371 branches covered (87.31%)

Branch coverage included in aggregate %.

1 of 2 new or added lines in 2 files covered. (50.0%)

2455 of 2533 relevant lines covered (96.92%)

80.07 hits per line