akvo / akvo-mis / #671

88%

main: 88%

Pull #237

coveralls-python

[#236] Refactor form_seeder onto shared FB-007 parser (NFR-6/D-8)

- form_seeder now parses every file via normalize -> validate ->
  import_form_definition; legacy source/forms/*.json keep working
- normalize: bridge legacy options->option and parent_id->parent_hint;
  validate: tolerate list-typed extra and non-dict fn/api in legacy files
- import_form_definition: new seeder-only kwargs require_parent=False
  (legacy monitoring fixtures without parent) and
  claim_foreign_questions=True (cross-form question moves keep their PK
  so answers stay linked); API behaviour unchanged
- Fix latent update-path bug: new groups/questions from an import file
  now preserve their exported IDs when free (FR-9/R-2) instead of
  getting fresh auto-IDs that silently broke later ID-based re-imports
- Seeder keeps answer migration, hard-delete of removed questions, QA
  attributes, publish-on-seed and version bumps; validation errors go
  to stderr in the shared {code, path, message} shape
- Verified nginx client_max_body_size 50M covers the 5 MB import cap
  (NFR-2 deployment note updated in design doc)

Tests: 17 seeder + 217 full v1_forms suite pass

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

5625 of 6538 branches covered (86.04%)

Branch coverage included in aggregate %.

10632 of 11871 relevant lines covered (89.56%)

0.9 hits per line